Skip to content

[ty] Upgrade Salsa#25545

Merged
MichaReiser merged 6 commits into
mainfrom
micha/ty-pull-in-salsa-1103
Jun 4, 2026
Merged

[ty] Upgrade Salsa#25545
MichaReiser merged 6 commits into
mainfrom
micha/ty-pull-in-salsa-1103

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Jun 2, 2026

Copy link
Copy Markdown
Member

Upgrade Salsa to 0.27 to pull in salsa-rs/salsa#1100

Closes astral-sh/ty#2378
Closes astral-sh/ty#3339

Test plan

Verified that the tests added in astral-sh/ruff#25463 now pass (we have similar tests now in Salsa, which is why I'm not adding them here)

@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label Jun 2, 2026
@astral-sh-bot

astral-sh-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 92.13%. The percentage of expected errors that received a diagnostic held steady at 87.18%. The number of fully passing files held steady at 92/134.

@astral-sh-bot

astral-sh-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

@astral-sh-bot

astral-sh-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@codspeed-hq

codspeed-hq Bot commented Jun 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 125 untouched benchmarks


Comparing micha/ty-pull-in-salsa-1103 (3fed00a) with main (85207d3)

Open in CodSpeed

@MichaReiser MichaReiser changed the title [ty] Pull in salsa-rs/salsa#1103 [ty] Upgrade Salsa Jun 4, 2026
@MichaReiser MichaReiser marked this pull request as ready for review June 4, 2026 07:41
@MichaReiser MichaReiser enabled auto-merge (squash) June 4, 2026 07:42
@MichaReiser MichaReiser merged commit 0d7135f into main Jun 4, 2026
58 checks passed
@MichaReiser MichaReiser deleted the micha/ty-pull-in-salsa-1103 branch June 4, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[panic] Panicked while checking: cancelled because of propagated panic panic on Tauon's codebase

1 participant