Skip to content

Use remaining source for token capacity estimates#25382

Merged
MichaReiser merged 1 commit into
micha/view-benchmark-token-capacityfrom
dhruv/pr-25354-token-capacity-offset
May 26, 2026
Merged

Use remaining source for token capacity estimates#25382
MichaReiser merged 1 commit into
micha/view-benchmark-token-capacityfrom
dhruv/pr-25354-token-capacity-offset

Conversation

@dhruvmanila

Copy link
Copy Markdown
Member

Summary

Test Plan

@astral-sh-bot

astral-sh-bot Bot commented May 25, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented May 25, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

Lint rule Added Removed Changed
not-iterable 0 0 1
Total 0 0 1

Raw diff:

dd-trace-py (https://github.com/DataDog/dd-trace-py)
- ddtrace/contrib/internal/subprocess/patch.py:321:44 error[not-iterable] Object of type `list[Unknown] | None | list[str] | ... omitted 3 union elements` may not be iterable
+ ddtrace/contrib/internal/subprocess/patch.py:321:44 error[not-iterable] Object of type `list[Unknown] | None | list[str] | Unknown | list[_T@deque | str]` may not be iterable

Full report with detailed diff (timing results)

@codspeed-hq

codspeed-hq Bot commented May 25, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 9.03%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 122 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory linter/default-rules[pydantic/types.py] 380.1 KB 348.7 KB +9.03%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dhruv/pr-25354-token-capacity-offset (46342f6) with micha/view-benchmark-token-capacity (5879173)

Open in CodSpeed

@astral-sh-bot

astral-sh-bot Bot commented May 25, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser reopened this May 26, 2026
@MichaReiser MichaReiser marked this pull request as ready for review May 26, 2026 12:39
@MichaReiser MichaReiser self-requested a review as a code owner May 26, 2026 12:39
@MichaReiser MichaReiser merged commit 2edc8c7 into micha/view-benchmark-token-capacity May 26, 2026
83 of 91 checks passed
@MichaReiser MichaReiser deleted the dhruv/pr-25354-token-capacity-offset branch May 26, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants