Skip to content

[ty] Add error context to invalid-return-type diagnostics #24770

Merged
sharkdp merged 1 commit into
mainfrom
david/invalid-return-type-error-ctx
Apr 21, 2026
Merged

[ty] Add error context to invalid-return-type diagnostics #24770
sharkdp merged 1 commit into
mainfrom
david/invalid-return-type-error-ctx

Conversation

@sharkdp

@sharkdp sharkdp commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Add error context to invalid-return-type diagnostics as well.

Test Plan

New snapshot test

@sharkdp sharkdp added the ty Multi-file analysis & type inference label Apr 21, 2026
@sharkdp sharkdp force-pushed the david/invalid-return-type-error-ctx branch from a69af11 to ae4a5dd Compare April 21, 2026 15:29
@astral-sh-bot

astral-sh-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133.

@astral-sh-bot

astral-sh-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@AlexWaygood AlexWaygood added the diagnostics Related to reporting of diagnostics. label Apr 21, 2026

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@sharkdp sharkdp merged commit 6c09271 into main Apr 21, 2026
56 checks passed
@sharkdp sharkdp deleted the david/invalid-return-type-error-ctx branch April 21, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diagnostics Related to reporting of diagnostics. ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants