[ty] Treat bad-fields functional TypedDict as a lenient fallback#24253
Closed
charliermarsh wants to merge 39 commits intocharlie/typed-dict-1from
Closed
[ty] Treat bad-fields functional TypedDict as a lenient fallback#24253charliermarsh wants to merge 39 commits intocharlie/typed-dict-1from
charliermarsh wants to merge 39 commits intocharlie/typed-dict-1from
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 86.50%. The percentage of expected errors that received a diagnostic held steady at 81.37%. The number of fully passing files held steady at 67/132. |
001485c to
9746f58
Compare
Memory usage reportMemory usage unchanged ✅ |
c98456b to
41e630e
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 41 | 0 | 0 |
Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.
Member
|
Ah, thanks for splitting this one out -- that does clarify things a bit. I didn't realise the special casing was quite so scattered across so many methods... I do still feel like having a lenient fallback is the correct thing to do in terms of the principle of the thing, but it probably doesn't matter that much -- and I'm not sure it's worth this much special casing. So maybe we should just leave it for now. It's pretty unlikely that anybody will complain about not having this. |
9746f58 to
df581ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See: #24174 (comment).