[ty] Support inheriting from functional TypedDict#24175
Merged
charliermarsh merged 1 commit intocharlie/typed-dict-1from Mar 27, 2026
Merged
[ty] Support inheriting from functional TypedDict#24175charliermarsh merged 1 commit intocharlie/typed-dict-1from
charliermarsh merged 1 commit intocharlie/typed-dict-1from
Conversation
dbb3a6d to
6953c16
Compare
9ea4c9b to
219fe84
Compare
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 86.50%. The percentage of expected errors that received a diagnostic held steady at 81.37%. The number of fully passing files held steady at 67/132. |
Memory usage reportMemory usage unchanged ✅ |
6953c16 to
c64acf6
Compare
219fe84 to
f911635
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-key |
0 | 4 | 0 |
invalid-argument-type |
0 | 2 | 0 |
| Total | 0 | 6 | 0 |
Raw diff:
meson (https://github.com/mesonbuild/meson)
- mesonbuild/cargo/manifest.py:557:54 error[invalid-argument-type] Argument to bound method `from_raw` is incorrect: Expected `BuildTarget`, found `dict[str, str]`
- mesonbuild/cargo/manifest.py:557:73 error[invalid-key] Unknown key "path" for TypedDict `BuildTarget`
- mesonbuild/cargo/manifest.py:563:54 error[invalid-argument-type] Argument to bound method `from_raw` is incorrect: Expected `BuildTarget`, found `dict[str, str]`
- mesonbuild/cargo/manifest.py:563:73 error[invalid-key] Unknown key "path" for TypedDict `BuildTarget`
prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/cli/version.py:45:48 error[invalid-key] Unknown key "full-revisionid" for TypedDict `VersionInfo`
- src/prefect/utilities/dockerutils.py:69:46 error[invalid-key] Unknown key "full-revisionid" for TypedDict `VersionInfo`c64acf6 to
abe5844
Compare
f911635 to
cd256ad
Compare
abe5844 to
ff459cb
Compare
cd256ad to
a9dd255
Compare
ff459cb to
e128468
Compare
a9dd255 to
6da784f
Compare
e128468 to
ed8bd3e
Compare
1edfdbc to
e80e895
Compare
f7f0130 to
12ce19c
Compare
e80e895 to
3bf53cd
Compare
Merging this PR will degrade performance by 19.97%
Performance Changes
Comparing 
Footnotes
|
AlexWaygood
reviewed
Mar 26, 2026
12ce19c to
7937696
Compare
3bf53cd to
d4f851b
Compare
505110e to
b5c10dd
Compare
f005931 to
39e2479
Compare
f1c8f9d to
7a59f8f
Compare
86a9862 to
6369ebb
Compare
6369ebb to
8c2a9cf
Compare
Member
Author
|
(Sorry, this accidentally got merged because I pushed a downstream local change to the upstream branch. I will re-open.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds handling for class-based TypedDicts that inherit from functional TypedDicts.
Part of: astral-sh/ty#3095.