[ty] Fix false-positive diagnostics for PEP-604 union annotations on attribute targets on Python 3.9 when from __future__ import annotations is active#23915
Merged
AlexWaygood merged 1 commit intomainfrom Mar 12, 2026
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 85.29%. The percentage of expected errors that received a diagnostic held steady at 78.13%. The number of fully passing files held steady at 64/132. |
…attribute targets on Python 3.9 when `from __future__ import annotations` is active
b4d7f5d to
2cbdd3a
Compare
|
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
prefect
sphinx
|
Member
Author
|
Whelp. I really should have checked the ecosystem report on #23285 more carefully. This might be bad enough to warrant a hotfix release 😬 |
ntBre
approved these changes
Mar 12, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Makes sense to me, for what it's worth!
carljm
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression introduced in 0.0.22 just now. This works fine at runtime, even on Python 3.9 -- because of
__future__.annotations, the annotation is never evaluated:but a latent bug in
infer/builder.rs(that must have been there for quite some time) meant that we weren't settingdeferred_statetoDeferredExpressionState::Deferredfor annotations on attribute expressions even when__future__.annotationswas imported -- we were only doing so for annotations on name expressions.This PR fixes the regression.
Test Plan
New mdtests