[ty] Fix type checking for multi-member enums within in a function block#23683
Merged
carljm merged 4 commits intoastral-sh:mainfrom Mar 3, 2026
Merged
[ty] Fix type checking for multi-member enums within in a function block#23683carljm merged 4 commits intoastral-sh:mainfrom
carljm merged 4 commits intoastral-sh:mainfrom
Conversation
Typing conformance results regressed ❌The percentage of diagnostics emitted that were expected errors decreased from 85.94% to 85.92%. The percentage of expected errors that received a diagnostic decreased from 78.17% to 78.13%. Summary
Optional Diagnostics RemovedDetails
|
|
Memory usage reportMemory usage unchanged ✅ |
Member
|
In this case the conformance suite "regressions" reported by our script are both actually good news :-) They're marked as "optional errors" in the upstream conformance suite because the spec does not mandate that type checkers have to infer precise Literal types on those lines — it's permitted for the assertions to fail. But if the assertions pass (and the optional errors are therefore not emitted), that's even better! |
Contributor
Author
|
@AlexWaygood Thanks for checking on that, I had moved this back to draft so I could look into it. Everything seems fine to me, so I'll mark it as ready again. |
carljm
approved these changes
Mar 3, 2026
Contributor
carljm
left a comment
There was a problem hiding this comment.
Thanks! Pushing a few updates I noticed and then will land if CI looks good.
|
|
||
| To do: <https://typing.python.org/en/latest/spec/enums.html#enum-definition> | ||
|
|
||
| ### `value` and `_value_` |
Contributor
There was a problem hiding this comment.
These tests don't belong under "Function syntax", and partly duplicate existing tests above.
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-argument-type |
2 | 0 | 1 |
unused-type-ignore-comment |
0 | 3 | 0 |
invalid-assignment |
2 | 0 | 0 |
redundant-cast |
1 | 0 | 0 |
type-assertion-failure |
1 | 0 | 0 |
unsupported-operator |
1 | 0 | 0 |
| Total | 7 | 3 | 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeErrors between an enum member'svalueattribute and the enum itself are silently suppressedwhen inside a function due to resolution as
AnyMinimal example:
Test Plan
crates/ty_python_semantic/resources/mdtest/enums.mdunder the Function Syntax heading