Skip to content

[ty] no-op change to test nondeterminism#23541

Closed
dcreager wants to merge 11 commits intodcreager/constraint-builderfrom
dcreager/test-builder-nondet
Closed

[ty] no-op change to test nondeterminism#23541
dcreager wants to merge 11 commits intodcreager/constraint-builderfrom
dcreager/test-builder-nondet

Conversation

@dcreager
Copy link
Member

@dcreager dcreager commented Feb 24, 2026

This is a no-op change to see if #23538 actually helps reduce nondeterminism.

@dcreager dcreager added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Feb 24, 2026
@AlexWaygood AlexWaygood added the do-not-merge Do not merge this pull request label Feb 24, 2026
@dcreager dcreager force-pushed the dcreager/test-builder-nondet branch from db670f6 to 3429aaf Compare February 24, 2026 17:07
@astral-sh-bot
Copy link

astral-sh-bot bot commented Feb 24, 2026 •
edited
Loading

Typing conformance results

No changes detected ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Feb 24, 2026 •
edited
Loading

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Feb 24, 2026 •
edited
Loading

mypy_primer results

Changes were detected when running on open source projects 
prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/deployments/runner.py:1017:70: error[unresolved-attribute] Attribute `__name__` is not defined on `((...) -> Any) & ((*args: object, **kwargs: object) -> object)` in union `Unknown | (((...) -> Any) & ((*args: object, **kwargs: object) -> object))`
+ src/prefect/deployments/runner.py:1017:70: error[unresolved-attribute] Attribute `__name__` is not defined on `(...) -> Any` in union `Unknown | ((...) -> Any)`
+ src/prefect/flow_engine.py:1004:32: error[invalid-await] `Unknown | R@FlowRunEngine | Coroutine[Any, Any, R@FlowRunEngine]` is not awaitable
+ src/prefect/flow_engine.py:1610:24: error[invalid-await] `Unknown | R@AsyncFlowRunEngine | Coroutine[Any, Any, R@AsyncFlowRunEngine]` is not awaitable
- src/prefect/flows.py:286:34: error[unresolved-attribute] Object of type `((**P@Flow) -> R@Flow) & ((*args: object, **kwargs: object) -> object)` has no attribute `__name__`
+ src/prefect/flows.py:286:34: error[unresolved-attribute] Object of type `(**P@Flow) -> R@Flow` has no attribute `__name__`
- src/prefect/flows.py:404:68: error[unresolved-attribute] Object of type `((**P@Flow) -> R@Flow) & ((*args: object, **kwargs: object) -> object)` has no attribute `__name__`
+ src/prefect/flows.py:404:68: error[unresolved-attribute] Object of type `(**P@Flow) -> R@Flow` has no attribute `__name__`
- Found 5779 diagnostics
+ Found 5781 diagnostics

@dcreager dcreager force-pushed the dcreager/test-builder-nondet branch from 3429aaf to 7448530 Compare February 25, 2026 03:02
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2026 •
edited
Loading

Merging this PR will improve performance by ×5.1

⚡ 3 improved benchmarks
✅ 23 untouched benchmarks
⏩ 30 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime sympy 69.1 s 66.3 s +4.16%
⚡ WallTime altair 5 s 4.8 s +4.04%
⚡ Simulation ty_micro[large_isinstance_narrowing] 721.8 ms 142.2 ms ×5.1

Comparing dcreager/test-builder-nondet (14621fe) with dcreager/constraint-builder (ab4ce4e)2

Open in CodSpeed

Footnotes

  1. 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on dcreager/constraint-builder (08b9d50) during the generation of this report, so f734717 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@dcreager dcreager force-pushed the dcreager/constraint-builder branch from c4a3779 to bcf548a Compare February 25, 2026 16:02
@dcreager dcreager force-pushed the dcreager/test-builder-nondet branch from 7448530 to f0e0070 Compare February 25, 2026 16:02
@dcreager dcreager force-pushed the dcreager/constraint-builder branch from bcf548a to ab4ce4e Compare February 25, 2026 16:08
@dcreager dcreager force-pushed the dcreager/test-builder-nondet branch from f0e0070 to 3a11412 Compare February 25, 2026 16:08
@astral-sh-bot
Copy link

astral-sh-bot bot commented Feb 25, 2026 •
edited
Loading

ecosystem-analyzer results

Lint rule Added Removed Changed
invalid-await 0 40 0
invalid-return-type 0 1 0
Total 0 41 0

Full report with detailed diff (timing results)

@dcreager dcreager mentioned this pull request Feb 26, 2026
Merged
@dcreager dcreager force-pushed the dcreager/test-builder-nondet branch from 3a11412 to 14621fe Compare February 27, 2026 02:57
@dcreager dcreager force-pushed the dcreager/constraint-builder branch 2 times, most recently from 08b9d50 to dbb1981 Compare February 27, 2026 18:21
@dcreager dcreager closed this Feb 27, 2026
@dcreager dcreager deleted the dcreager/test-builder-nondet branch February 27, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge Do not merge this pull request ecosystem-analyzer internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcreager @AlexWaygood