[pyupgrade] Fix false positive for TypeVar default before 3.12 (UP046)#23540
Merged
[pyupgrade] Fix false positive for TypeVar default before 3.12 (UP046)#23540
pyupgrade] Fix false positive for TypeVar default before 3.12 (UP046)#23540Conversation
this should not have a diagnostic because it uses a TypeVar with a default
pyupgrade]pyupgrade] Fix false positive for TypeVar default before 3.12 (UP046)
charliermarsh
approved these changes
Feb 24, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This was reported on Discord:
In short,
UP046was suggesting to use PEP-695 type parameters in the second class on Python versions before 3.13 despite_Capsusing adefault, which is only supported in PEP-695 type parameters on 3.13 and later.The fix looks unrelated at first glance, but this early return was preventing the diagnostic from being defused later for having a
default.Test Plan
New test derived from the report