Conversation
Summary -- This PR partially addresses #23267. This warning is now implemented as the RUF102 lint rule, so we can get rid of the warning. There's actually a second instance of this warning (the only variant with tests) for file-level `noqa`s. As I noted on the issue, these aren't actually covered by RUF102, but I think we should make that change and remove that warning separately. Test Plan -- Manual testing: ```console ❯ ruff check --select RUF102 --output-format=concise --no-cache - <<EOF 1 # noqa: X111 EOF warning: Invalid rule code provided to `# noqa` at -:1: X111 -:1:3: RUF102 [*] Invalid rule code in `# noqa`: X111 Found 1 error. [*] 1 fixable with the `--fix` option. astral/worktrees/ruff1 on brent/ruf102-warning [$?] is 📦 v0.15.1 via 🐍 v3.14.2 via 🦀 v1.93.0 ❯ cargo run -p ruff -- check --select RUF102 --output-format=concise --no-cache - <<EOF 1 # noqa: X111 EOF -:1:3: RUF102 [*] Invalid rule code in `# noqa`: X111 Found 1 error. [*] 1 fixable with the `--fix` option. ```
amyreese
approved these changes
Feb 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially addresses #23267. This warning is now implemented as the
RUF102 lint rule, so we can get rid of the warning.
There's actually a second instance of this warning (the only variant with tests)
for file-level
noqas. As I noted on the issue, these aren't actually coveredby RUF102, but I think we should make that change and remove that warning
separately.
Test Plan
Manual testing: