Skip to content

Remove invalid inline noqa warning#23270

Merged
ntBre merged 1 commit intomainfrom
brent/ruf102-warning
Feb 18, 2026
Merged

Remove invalid inline noqa warning#23270
ntBre merged 1 commit intomainfrom
brent/ruf102-warning

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Feb 13, 2026

Summary

This PR partially addresses #23267. This warning is now implemented as the
RUF102 lint rule, so we can get rid of the warning.

There's actually a second instance of this warning (the only variant with tests)
for file-level noqas. As I noted on the issue, these aren't actually covered
by RUF102, but I think we should make that change and remove that warning
separately.

Test Plan

Manual testing:

ruff check --select RUF102 --output-format=concise --no-cache - <<EOF
1 # noqa: X111
EOF
warning: Invalid rule code provided to `# noqa` at -:1: X111
-:1:3: RUF102 [*] Invalid rule code in `# noqa`: X111
Found 1 error.
[*] 1 fixable with the `--fix` option.cargo run -p ruff -- check --select RUF102 --output-format=concise --no-cache - <<EOF
1 # noqa: X111
EOF
-:1:3: RUF102 [*] Invalid rule code in `# noqa`: X111
Found 1 error.
[*] 1 fixable with the `--fix` option.

Summary
--

This PR partially addresses #23267. This warning is now implemented as the
RUF102 lint rule, so we can get rid of the warning.

There's actually a second instance of this warning (the only variant with tests)
for file-level `noqa`s. As I noted on the issue, these aren't actually covered
by RUF102, but I think we should make that change and remove that warning
separately.

Test Plan
--

Manual testing:

```console
❯ ruff check --select RUF102 --output-format=concise --no-cache - <<EOF
1 # noqa: X111
EOF
warning: Invalid rule code provided to `# noqa` at -:1: X111
-:1:3: RUF102 [*] Invalid rule code in `# noqa`: X111
Found 1 error.
[*] 1 fixable with the `--fix` option.

astral/worktrees/ruff1 on  brent/ruf102-warning [$?] is 📦 v0.15.1 via 🐍 v3.14.2 via 🦀 v1.93.0
❯ cargo run -p ruff -- check --select RUF102 --output-format=concise --no-cache - <<EOF
1 # noqa: X111
EOF
-:1:3: RUF102 [*] Invalid rule code in `# noqa`: X111
Found 1 error.
[*] 1 fixable with the `--fix` option.
```
@ntBre ntBre added the cli Related to the command-line interface label Feb 13, 2026
@astral-sh-bot
Copy link

astral-sh-bot bot commented Feb 13, 2026

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre merged commit f5b61be into main Feb 18, 2026
43 checks passed
@ntBre ntBre deleted the brent/ruf102-warning branch February 18, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the command-line interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants