[ty] Fix union *args binding for optional positional parameters#23124
Merged
charliermarsh merged 9 commits intomainfrom Mar 4, 2026
Merged
[ty] Fix union *args binding for optional positional parameters#23124charliermarsh merged 9 commits intomainfrom
*args binding for optional positional parameters#23124charliermarsh merged 9 commits intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅ |
|
3723f86 to
f368018
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
invalid-argument-type |
0 | 1 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 41 | 1 | 0 |
AlexWaygood
reviewed
Feb 10, 2026
carljm
requested changes
Feb 14, 2026
Contributor
carljm
left a comment
There was a problem hiding this comment.
Thanks! I think there are some thing to look at here.
f368018 to
23e6f38
Compare
Memory usage reportMemory usage unchanged ✅ |
23e6f38 to
f1c1699
Compare
carljm
approved these changes
Mar 3, 2026
Contributor
carljm
left a comment
There was a problem hiding this comment.
This looks much better! Just a couple comments on test coverage. It's not clear to me if the new bounded variable is actually needed or not -- test coverage would help clarify.
543b269 to
188ce13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#2734.