refactor CLI (1/3): Cosmetic changes#2145
Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom Jan 26, 2023
Merged
Conversation
6c8cc8c to
0b59370
Compare
Member
|
LGTM, but now has a conflict (sorry!) |
Technically the command-line interface (CLI) encompasses both input and output, so naming the input structs 'Args' is more accurate than 'Cli'.
0b59370 to
2de1aa2
Compare
2de1aa2 to
886b887
Compare
Contributor
Author
|
Rebased :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the many-to-many mapping I wanted to introduce a new subcommand ... only to end up refactoring the whole
ruff_cli::cli::Clistruct.This CLI refactor has gotten so large that I'll split it up in two PRs (this PR contains the purely cosmetic changes, the next PR will contain the larger refactors).