Skip to content

Implement EXE001 and EXE002 from flake8-executable#2118

Merged
charliermarsh merged 6 commits intoastral-sh:mainfrom
edgarrmondragon:feat/exe001-exe002
Jan 24, 2023
Merged

Implement EXE001 and EXE002 from flake8-executable#2118
charliermarsh merged 6 commits intoastral-sh:mainfrom
edgarrmondragon:feat/exe001-exe002

Conversation

@edgarrmondragon
Copy link
Copy Markdown
Contributor

@edgarrmondragon
Copy link
Copy Markdown
Contributor Author

I think the clippy check for wasm is failing because Metadata.mode() is only available on Unix

@charliermarsh charliermarsh merged commit f5f0ed2 into astral-sh:main Jan 24, 2023
@basnijholt
Copy link
Copy Markdown

These shouldn't be executed on Windows.

@charliermarsh
Copy link
Copy Markdown
Member

How do the Unix extensions even compile on Windows?

@basnijholt
Copy link
Copy Markdown

basnijholt commented Feb 22, 2023

I noticed this because pre-commit running on windows-latest Azure DevOps agents, failed, where the Linux jobs pass.

I just pip install ruff there ¯\(ツ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants