Skip to content

Conversation

@Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Oct 23, 2025

Summary

  • Extend airflow.models.Param to include airflow.models.param.Param case and include both airflow.models.param.ParamDict and airflow.models.param.DagParam and their airflow.models. counter part

Test Plan

update the text fixture accordingly and reorganize them in the third commit

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+2 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

apache/airflow (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ providers/edge3/src/airflow/providers/edge3/example_dags/integration_test.py:65:26: AIR311 `airflow.models.param.Param` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
+ providers/edge3/src/airflow/providers/edge3/example_dags/integration_test.py:73:27: AIR311 `airflow.models.param.Param` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
AIR311 2 2 0 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+2 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

apache/airflow (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ providers/edge3/src/airflow/providers/edge3/example_dags/integration_test.py:65:26: AIR311 `airflow.models.param.Param` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
+ providers/edge3/src/airflow/providers/edge3/example_dags/integration_test.py:73:27: AIR311 `airflow.models.param.Param` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
AIR311 2 2 0 0 0

@Lee-W Lee-W changed the title [airflow] Extend airflow.sdk.definitions.param.Param replacement to all airflow.models..Param (AIR311) [airflow] Extend airflow.models..Param check (AIR311) Oct 23, 2025
@Lee-W Lee-W mentioned this pull request Oct 23, 2025
2 tasks
Copy link

@zach-overflow zach-overflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ntBre ntBre self-requested a review October 23, 2025 18:17
@ntBre ntBre added the rule Implementing or modifying a lint rule label Oct 23, 2025
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ntBre ntBre merged commit 05cde8b into astral-sh:main Oct 23, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants