-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[airflow] Extend airflow.models..Param check (AIR311)
#21043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR311 | 2 | 2 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+2 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)
apache/airflow (+2 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
+ providers/edge3/src/airflow/providers/edge3/example_dags/integration_test.py:65:26: AIR311 `airflow.models.param.Param` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version. + providers/edge3/src/airflow/providers/edge3/example_dags/integration_test.py:73:27: AIR311 `airflow.models.param.Param` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR311 | 2 | 2 | 0 | 0 | 0 |
airflow] Extend airflow.sdk.definitions.param.Param replacement to all airflow.models..Param (AIR311)airflow] Extend airflow.models..Param check (AIR311)
zach-overflow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
ntBre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Summary
airflow.models.Paramto includeairflow.models.param.Paramcase and include bothairflow.models.param.ParamDictandairflow.models.param.DagParamand theirairflow.models.counter partTest Plan
update the text fixture accordingly and reorganize them in the third commit