Merged
Conversation
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
a46a4d7 to
9b834d6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
ibraheemdev
approved these changes
Oct 2, 2025
MichaReiser
approved these changes
Oct 2, 2025
Cargo.toml
Outdated
| tikv-jemallocator = { version = "0.6.0" } | ||
| toml = { version = "0.9.0" } | ||
| tracing = { version = "0.1.40" } | ||
| tracing = { version = "0.1.40", features = ["log"] } |
Member
There was a problem hiding this comment.
Can we only enable this in ty_wasm?
It makes it a bit easier to reason about the change
Member
Author
There was a problem hiding this comment.
I think it makes sense to enable this "globally," but I get wanting to do it narrowly. I've switched the PR to enabling log only for ty_wasm.
9b834d6 to
8238725
Compare
This has the effect of emitting tracing events via `log` whenever there isn't an active tracing subscriber present. This makes it so `ty_wasm` logs tracing messages to the JavaScript console automatically (via our use of `console_log`).
Previously, we would always add `/{*filepath}` as our wildcard to match
descendant paths. But when the root is just `/` (as it can be in tests,
weird environments or in the ty playground), this causes a double `/`
and inhibits most descendant matches.
The regression test added in this commit fails without this fix.
Specifically, it panics because it can't find a file root for
`/project`.
Fixes #1277
8238725 to
f67114b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would always add
/{*filepath}as our wildcard to matchdescendant paths. But when the root is just
/(as it can be in tests,weird environments or in the ty playground), this causes a double
/and inhibits most descendant matches.
The regression test added in this commit fails without this fix.
Specifically, it panics because it can't find a file root for
/project.This also enables the
logfeature ontracing, which means we getbetter debug messages in the JavaScript console when running the
playground.
Fixes astral-sh/ty#1277