[ty] fix lookup order of class variables before they are defined#19743
Merged
carljm merged 2 commits intoastral-sh:mainfrom Aug 5, 2025
Merged
[ty] fix lookup order of class variables before they are defined#19743carljm merged 2 commits intoastral-sh:mainfrom
carljm merged 2 commits intoastral-sh:mainfrom
Conversation
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
Contributor
|
The ecosystem hit looks like a true positive to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #19321.
If we try to access a class variable before it is defined, the variable is looked up in the global scope, rather than in any enclosing scopes.
Closes astral-sh/ty#875.
Test Plan
New tests in
narrow/conditionals/nested.md.