[flake8-logging] Add fix safety section to LOG001#18841
Merged
dylwil3 merged 2 commits intoastral-sh:mainfrom Jun 23, 2025
Merged
[flake8-logging] Add fix safety section to LOG001#18841dylwil3 merged 2 commits intoastral-sh:mainfrom
flake8-logging] Add fix safety section to LOG001#18841dylwil3 merged 2 commits intoastral-sh:mainfrom
Conversation
Contributor
|
dylwil3
approved these changes
Jun 23, 2025
crates/ruff_linter/src/rules/flake8_logging/rules/direct_logger_instantiation.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #15584
This adds a
Fix safetysection to direct-logger-instantiation (LOG001).The fix/lint was introduced in #7397
No reasoning is given on the unsafety in the PR/code
Unsafe fix demonstration:
playground
Test Plan
N/A, no tests/functionality affected