Skip SIM108 violations for complex if-statements#1802
Merged
charliermarsh merged 1 commit intomainfrom Jan 12, 2023
Merged
Conversation
bruxisma
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jan 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.218` -> `^0.0.219` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.219`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.219) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.218...v0.0.219) #### What's Changed - Disable update check by default by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1786](https://togithub.com/charliermarsh/ruff/pull/1786) - Improve PIE794 autofix behavior by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1794](https://togithub.com/charliermarsh/ruff/pull/1794) - Convert flake8-comprehensions checks to Checker style by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1795](https://togithub.com/charliermarsh/ruff/pull/1795) - Refactor flake8-comprehensions rules to take fewer arguments by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1797](https://togithub.com/charliermarsh/ruff/pull/1797) - Avoid rewriting flake8-comprehensions expressions for builtin overrides by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1799](https://togithub.com/charliermarsh/ruff/pull/1799) - Update readme to reflect [#​1763](https://togithub.com/charliermarsh/ruff/issues/1763) by [@​Czaki](https://togithub.com/Czaki) in [https://github.com/charliermarsh/ruff/pull/1780](https://togithub.com/charliermarsh/ruff/pull/1780) - Avoid flagging builtins for OSError rewrites by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1800](https://togithub.com/charliermarsh/ruff/pull/1800) - Skip unused argument checks for magic methods by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1801](https://togithub.com/charliermarsh/ruff/pull/1801) - Skip SIM108 violations for complex if-statements by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1802](https://togithub.com/charliermarsh/ruff/pull/1802) - \[`flake8-simplify`] Add Rule for `SIM115` (Use context handler for opening files) by [@​saadmk11](https://togithub.com/saadmk11) in [https://github.com/charliermarsh/ruff/pull/1782](https://togithub.com/charliermarsh/ruff/pull/1782) - flake8\_simplify : SIM401 by [@​chammika-become](https://togithub.com/chammika-become) in [https://github.com/charliermarsh/ruff/pull/1778](https://togithub.com/charliermarsh/ruff/pull/1778) - Avoid erroneous Q002 error message for single-quote docstrings by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/1777](https://togithub.com/charliermarsh/ruff/pull/1777) - Implement doc line length enforcement by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1804](https://togithub.com/charliermarsh/ruff/pull/1804) - Move top level `ruff` into `python` folder by [@​messense](https://togithub.com/messense) in [https://github.com/charliermarsh/ruff/pull/1806](https://togithub.com/charliermarsh/ruff/pull/1806) - Improve globset documentation and help message by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1808](https://togithub.com/charliermarsh/ruff/pull/1808) #### New Contributors - [@​Czaki](https://togithub.com/Czaki) made their first contribution in [https://github.com/charliermarsh/ruff/pull/1780](https://togithub.com/charliermarsh/ruff/pull/1780) **Full Changelog**: astral-sh/ruff@v0.0.218...v0.0.219 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45OC4xIiwidXBkYXRlZEluVmVyIjoiMzQuOTguMSJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now skip SIM108 violations if: the resulting statement would exceed the user-specified line length, or the
ifstatement contains comments.Closes #1719.
Closes #1766.