[flake8-self] Ignore attribute accesses on instance-like variables (SLF001)#16149
Merged
MichaReiser merged 4 commits intoastral-sh:mainfrom Feb 23, 2025
Merged
[flake8-self] Ignore attribute accesses on instance-like variables (SLF001)#16149MichaReiser merged 4 commits intoastral-sh:mainfrom
flake8-self] Ignore attribute accesses on instance-like variables (SLF001)#16149MichaReiser merged 4 commits intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| SLF001 | 14 | 0 | 14 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -14 violations, +0 -0 fixes in 3 projects; 52 projects unchanged)
apache/airflow (+0 -6 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- airflow/io/path.py:365:17: SLF001 Private member accessed: `_cp_file` - airflow/models/serialized_dag.py:218:36: SLF001 Private member accessed: `_data` - airflow/models/serialized_dag.py:219:47: SLF001 Private member accessed: `_data_compressed` - airflow/models/taskinstance.py:3084:84: SLF001 Private member accessed: `_execute_task` - providers/databricks/src/airflow/providers/databricks/hooks/databricks.py:716:13: SLF001 Private member accessed: `_do_api_call` - task_sdk/src/airflow/sdk/execution_time/supervisor.py:375:9: SLF001 Private member accessed: `_register_pipe_readers`
apache/superset (+0 -3 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- superset/migrations/shared/migrate_viz/base.py:127:9: SLF001 Private member accessed: `_pre_action` - superset/migrations/shared/migrate_viz/base.py:128:9: SLF001 Private member accessed: `_migrate` - superset/migrations/shared/migrate_viz/base.py:129:9: SLF001 Private member accessed: `_post_action`
bokeh/bokeh (+0 -5 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- src/bokeh/model/model.py:105:13: SLF001 Private member accessed: `_id` - src/bokeh/model/model.py:107:13: SLF001 Private member accessed: `_id` - src/bokeh/protocol/message.py:200:9: SLF001 Private member accessed: `_header_json` - src/bokeh/protocol/message.py:201:9: SLF001 Private member accessed: `_metadata_json` - src/bokeh/protocol/message.py:202:9: SLF001 Private member accessed: `_content_json`
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| SLF001 | 14 | 0 | 14 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
686bd0d to
7b1cc72
Compare
Contributor
Author
|
Ecosystem changes are all as expected. |
ntBre
reviewed
Feb 14, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me, but I'd like someone more familiar with the TypeChecker API to have a look too. Maybe @AlexWaygood or @MichaReiser?
MichaReiser
approved these changes
Feb 17, 2025
Member
MichaReiser
left a comment
There was a problem hiding this comment.
I think this overall is an improvement. Will this be a deviation from the upstream rule?
crates/ruff_linter/src/rules/flake8_self/rules/private_member_access.rs
Outdated
Show resolved
Hide resolved
7b1cc72 to
16e6426
Compare
Contributor
Author
|
@MichaReiser This would be a deviation, yes, but the rule already contains multiple such deviations. The upstream rule exempts |
MichaReiser
approved these changes
Feb 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #9022.
SLF001now recognizes the following as instance-like and will not report them:cls()/mcs()super().__new__()SameClass()/SameClass[int]()/Annotated[SameClass[int], ...]()a: SameClass/a: SameClass[int]/a: Annotated[SameClass[int], ...]The new logic prioritizes avoiding false positives over avoiding false negatives. As the issue is labeled as a bug, the changes are not preview-gated.
Test Plan
cargo nextest runandcargo insta test.