[pylint] Preserve original value format (PLR6104)#14978
[pylint] Preserve original value format (PLR6104)#14978MichaReiser merged 11 commits intoastral-sh:mainfrom
pylint] Preserve original value format (PLR6104)#14978Conversation
|
|
The existing implementation is surprisingly complex. On top of that, it uses the generator to create the fix, but that's not strictly necessary. String slicing is much simpler and only requires an extra hardcoded |
MichaReiser
left a comment
There was a problem hiding this comment.
Thanks. Could you revert your changes to AugmentedOperator (and, if there are any, other refactors that aren't strictly necessary for the fix). I'd prefer to keep the changes minimal to the fix or have separate PRs for refactor and fix.
|
I'd like to believe it isn't my fault that the |
I believe it's due to one of the mdformat plugins we use having released a new version. We don't have these pinned in our pre-commit config file; we probably should. Two of the plugins we use cut new releases a couple of hours ago, one of them a major version bump: |
|
I filed #14992 to fix the pre-commit issue. |
crates/ruff_linter/src/rules/pylint/rules/non_augmented_assignment.rs
Outdated
Show resolved
Hide resolved
…ment.rs Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Summary
Resolves #11672.
Test Plan
cargo nextest runandcargo insta test.