Skip to content

[pylint] Fix false negatives for ascii and sorted in len-as-condition (PLC1802)#14692

Merged
dylwil3 merged 1 commit intoastral-sh:mainfrom
sbrugman:PLC1802-false-negatives
Nov 30, 2024
Merged

[pylint] Fix false negatives for ascii and sorted in len-as-condition (PLC1802)#14692
dylwil3 merged 1 commit intoastral-sh:mainfrom
sbrugman:PLC1802-false-negatives

Conversation

@sbrugman
Copy link
Contributor

@sbrugman sbrugman commented Nov 30, 2024

Summary

Fixes #14690.

Test Plan

Added test cases.

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Collaborator

@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dylwil3 dylwil3 added the rule Implementing or modifying a lint rule label Nov 30, 2024
@dylwil3 dylwil3 merged commit 56ae73a into astral-sh:main Nov 30, 2024
@sbrugman sbrugman deleted the PLC1802-false-negatives branch November 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PLC1802 has false negatives for ascii and sorted

2 participants