Fixes minor bug in SemanticModel::lookup_symbol#14643
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Nov 27, 2024
Merged
Fixes minor bug in SemanticModel::lookup_symbol#14643charliermarsh merged 1 commit intoastral-sh:mainfrom
SemanticModel::lookup_symbol#14643charliermarsh merged 1 commit intoastral-sh:mainfrom
Conversation
Contributor
|
charliermarsh
approved these changes
Nov 27, 2024
Member
|
Thanks for following up! I really appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This came up as part of #12927 when implementing
SemanticModel::simulate_runtime_load.Should be fairly self-explanatory, if the scope returns a binding with
BindingKind::Annotationthe bottom part of the loop gets skipped, so there's no chance forseen_functionto have been updated. So unless there's something subtle going on here, like function scopes never containing bindings withBindingKind::Annotation, this seems like a bug.Test Plan
cargo nextest run