doc(B024): #14455 add annotated but unassgined class variables#14502
Merged
dylwil3 merged 2 commits intoastral-sh:mainfrom Nov 21, 2024
Merged
doc(B024): #14455 add annotated but unassgined class variables#14502dylwil3 merged 2 commits intoastral-sh:mainfrom
dylwil3 merged 2 commits intoastral-sh:mainfrom
Conversation
8d22dfc to
6b5ae73
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| B024 | 4 | 2 | 2 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+2 -2 violations, +0 -0 fixes in 2 projects; 52 projects unchanged)
DisnakeDev/disnake (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- disnake/app_commands.py:468:7: B024 `ApplicationCommand` is an abstract base class, but it has no abstract methods + disnake/app_commands.py:468:7: B024 `ApplicationCommand` is an abstract base class, but it has no abstract methods or properties
apache/airflow (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- airflow/secrets/base_secrets.py:26:7: B024 `BaseSecretsBackend` is an abstract base class, but it has no abstract methods + airflow/secrets/base_secrets.py:26:7: B024 `BaseSecretsBackend` is an abstract base class, but it has no abstract methods or properties
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| B024 | 4 | 2 | 2 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
dylwil3
requested changes
Nov 21, 2024
Collaborator
dylwil3
left a comment
There was a problem hiding this comment.
This looks great, thank you! Minor nit and then we'll merge it in.
crates/ruff_linter/src/rules/flake8_bugbear/rules/abstract_base_class.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_bugbear/rules/abstract_base_class.rs
Outdated
Show resolved
Hide resolved
6b5ae73 to
680b199
Compare
dylwil3
approved these changes
Nov 21, 2024
Member
|
@dylwil3 it's fine to merge documentation changes because we rarely mention them in the changelog 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14455, migrated from astral-sh/docs#106.
Test Plan
Updating the documentation probably does not need a test.