Extend test cases for flake8-pyi#14280
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Nov 26, 2024
Merged
Conversation
AlexWaygood
reviewed
Nov 11, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
This has merge conflicts; could you take a look?
Contributor
Author
1d8778e to
930c017
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the test cases for a couple of flake8-pyi rules with nested and mixed union annotations.
Although these are rare, they are valid:
We should be able to handle them anyhow, as users or fixes might write these accidentally.
Test Plan
The snapshots are updated with the as-is behaviour.
I'll follow up with a change to the nested union logic. Having these tests in place before makes it easier to review the diff.