[refurb] Further special cases added to verbose-decimal-constructor (FURB157)#14216
Merged
charliermarsh merged 2 commits intoastral-sh:mainfrom Nov 9, 2024
Merged
[refurb] Further special cases added to verbose-decimal-constructor (FURB157)#14216charliermarsh merged 2 commits intoastral-sh:mainfrom
refurb] Further special cases added to verbose-decimal-constructor (FURB157)#14216charliermarsh merged 2 commits intoastral-sh:mainfrom
Conversation
Contributor
|
charliermarsh
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accounts for further subtleties in
Decimalparsing:Decimal("-0")is skippedDecimal("{integer literal that is longer than 640 digits}")are skipped (see linked issue for explanation)NB: The snapshot did not need to be updated since the new test cases are "Ok" instances and added below the diff.
Closes #14204