Merged
Conversation
Contributor
|
dhruvmanila
approved these changes
Nov 6, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where we emitted duplicated diagnostics for unpack assignments.
The solution is fairly simple. All we need is a deterministic way to know when we should add the
diagnostics. The approach I used here is only to add the diagnostics for the first unpacking.
This works because
check_typespulls all types.What about accumulators. We may still want to use accumulators in the future, e.g. if other, non type checking queries start emitting diagnostics. However, we have to solve the performance regression first. I have an idea on how that could be done. See the zulip discussion
Test Plan
See updated mdtest