Remove unpack field from SemanticIndexBuilder#14101
Merged
dhruvmanila merged 1 commit intomainfrom Nov 6, 2024
Merged
Conversation
1 task
Contributor
|
MichaReiser
approved these changes
Nov 5, 2024
| } | ||
|
|
||
| impl DefinitionNodeRef<'_> { | ||
| impl<'db> DefinitionNodeRef<'db> { |
Member
There was a problem hiding this comment.
Nit: I would use 'a here to be consistent with the DefinitionNodeRef definition and we don't use db here
Member
Author
There was a problem hiding this comment.
I think the main reason to use 'db here is because I've used that in DefinitionKind as well which is the return type of DefinitionNodeRef::into_owned function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #13979 (comment), this PR removes the
current_unpackstate field fromSemanticIndexBuilderand passes theUnpackingredient via theCurrentAssignment->DefinitionNodeRefconversion to finally store it onDefintionNodeKind.This involves updating the lifetime of
AnyParameterRef(parameter todeclare_parameter) to use the'dblifetime. Currently, all AST nodes stored on various enums are marked with'alifetime but they're always utilized using the'dblifetime.This also removes the dedicated
'alifetime parameter onadd_definitionwhich is currently being used inDefinitionNodeRef. As mentioned, all AST nodes live through the'dblifetime so we can remove the'alifetime parameter from that method and use the'dblifetime instead.