Skip to content

[red-knot] Minor follow-up on slice expression inference#13982

Merged
sharkdp merged 4 commits intomainfrom
david/slice-inference-follow-up
Oct 29, 2024
Merged

[red-knot] Minor follow-up on slice expression inference#13982
sharkdp merged 4 commits intomainfrom
david/slice-inference-follow-up

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Oct 29, 2024

Summary

Minor follow-up to #13917 — thanks @AlexWaygood for the post-merge review.

Test Plan

@carljm
Copy link
Contributor

carljm commented Oct 29, 2024

Looks like clippy wants you to pass SliceLiteralType by value.

@sharkdp sharkdp force-pushed the david/slice-inference-follow-up branch from 4ab20ba to 915f03c Compare October 29, 2024 19:35
@sharkdp sharkdp enabled auto-merge (squash) October 29, 2024 19:36
@sharkdp sharkdp merged commit 96b3c40 into main Oct 29, 2024
@sharkdp sharkdp deleted the david/slice-inference-follow-up branch October 29, 2024 19:40
@AlexWaygood
Copy link
Member

Thank you!!

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants