[pycodestyle] Fix whitespace-related false positives and false negatives inside type-parameter lists#13704
Merged
AlexWaygood merged 2 commits intomainfrom Oct 10, 2024
Merged
[pycodestyle] Fix whitespace-related false positives and false negatives inside type-parameter lists#13704AlexWaygood merged 2 commits intomainfrom
pycodestyle] Fix whitespace-related false positives and false negatives inside type-parameter lists#13704AlexWaygood merged 2 commits intomainfrom
Conversation
b4db57a to
d99ae7b
Compare
MichaReiser
reviewed
Oct 10, 2024
crates/ruff_linter/src/rules/pycodestyle/rules/logical_lines/missing_whitespace.rs
Outdated
Show resolved
Hide resolved
Contributor
|
d99ae7b to
1f39a4b
Compare
dhruvmanila
reviewed
Oct 10, 2024
crates/ruff_linter/src/rules/pycodestyle/rules/logical_lines/mod.rs
Outdated
Show resolved
Hide resolved
...linter/src/rules/pycodestyle/rules/logical_lines/whitespace_around_named_parameter_equals.rs
Outdated
Show resolved
Hide resolved
dhruvmanila
approved these changes
Oct 10, 2024
Member
dhruvmanila
left a comment
There was a problem hiding this comment.
Thanks for fixing this! I leave the decision on whether to implement the optimization or not to you if it's feasible before the 0.7 release otherwise that can be deferred for later. I don't see any regression so it might be ok.
…tives inside type-parameter lists
cedaa2d to
255ae25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13699.
We had false positives and false negatives regarding whitespace in type-parameter lists, that led to conflicts between the linter and the formatter. Specifically, we emitted a false positive here:
and a false negative here:
This PR adds a
TypeParamsStateenum, to keep track of whether we're currently visiting theLogicalLineTokens in a type parameters list or not. The common solution is then used to fix the bugs in both rules.Type parameter lists are new syntax that is only available in Python 3.13+, which is why this is only coming up now.
Test Plan
Fixtures have been added with examples of both class and function definitions that have type parameters