Don't skip over imports and other nodes containing nested statements in import collector#13521
Merged
MichaReiser merged 6 commits intomainfrom Sep 26, 2024
Merged
Conversation
…in import collector
d1b2bda to
e2e2a13
Compare
Contributor
|
Merged
Member
Author
|
Let me add a test for this |
charliermarsh
approved these changes
Sep 26, 2024
e2e2a13 to
c5b46f2
Compare
6c21504 to
8d77e0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up for #13441
enter_nodeis called for every node and it's important that it returnstruefor any node betweenModModuleand an import statement, including the import statement itself.Getting this right in
enter_nodeseems hard and it's easy to forget adding a new "include" when a new compound statement gets added.This PR moves the traversal logic into the
visist_stmtby requiring explicit match arms for each statement. I think this is easier to understandand less error prone.
Also...
enter_nodedoesn't get call when a visitor overridesvisit_stmt. That's an oversight from my side when designing the visitor.