Playground: Fix errors not shown on page load#13262
Merged
MichaReiser merged 1 commit intomainfrom Sep 9, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in the playground where errors for a restored snipped didn't show on page load.
The core issue was that
editororeditor.getModelswasNonewhen the diagnostics are updated, in which case theuseEffectskips the diagnostics change.This PR fixes the issue by:
onMountinstead ofbeforeMountto only set the editor instance when the editor is fully loadedhandleMountcallback because the mount event could be triggered after are updatedI used this as a chance to only register a single code action provider.
Fixes #11918
Test Plan
Screencast.from.2024-09-06.10-00-24.webm