Skip to content

[pylint] - fix incorrect starred expression replacement for nested-min-max (PLW3301)#13089

Merged
dhruvmanila merged 2 commits intoastral-sh:mainfrom
diceroll123:fix-PLW3301-issue
Aug 26, 2024
Merged

[pylint] - fix incorrect starred expression replacement for nested-min-max (PLW3301)#13089
dhruvmanila merged 2 commits intoastral-sh:mainfrom
diceroll123:fix-PLW3301-issue

Conversation

@diceroll123
Copy link
Copy Markdown
Contributor

Summary

Moves the min/max detection up, and fixes #13088

Test Plan

cargo test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 25, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhruvmanila dhruvmanila added the bug Something isn't working label Aug 26, 2024
@dhruvmanila dhruvmanila merged commit 5af4833 into astral-sh:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PLW3301 (nested-min-max) Autofix inappropriately strips nested function call when the nested function call wasn't max

2 participants