[flake8-async] Fix false positives with multiple async with items (ASYNC100)#12643
Merged
charliermarsh merged 2 commits intoastral-sh:mainfrom Aug 2, 2024
Merged
[flake8-async] Fix false positives with multiple async with items (ASYNC100)#12643charliermarsh merged 2 commits intoastral-sh:mainfrom
async with items (ASYNC100)#12643charliermarsh merged 2 commits intoastral-sh:mainfrom
Conversation
bluetech
commented
Aug 2, 2024
|
|
||
|
|
||
| async def func(): | ||
| async with trio.fail_after(): |
Contributor
Author
There was a problem hiding this comment.
The trio and anyio context managers are not async. The difference is relevant for this change, so I changed them back to with, this way we test both with and async with (asyncio).
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Please see #12605 (comment) for a description of the issue.
They way I fixed it is to get the last timeout item in the
with, and if it's anasync withand there are items after it, then don't trigger the lint.Test Plan
Updated the fixture with some more cases.