[red-knot] use a simpler builtin in the benchmark#12393
Merged
Conversation
Member
|
I beat you by four minutes! :-) #12392 |
Contributor
Author
|
Yeah but can we go with this one anyway, since I already rebased the next PR on top of it? :) I thought you said you were gonna quit for the day! |
Member
Micha started reviewing! I couldn't go just when all the fun was starting 😆 |
AlexWaygood
approved these changes
Jul 18, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for supporting resolving builtins, simplify the benchmark so it doesn't look up
str, which is actually a complex builtin to deal with because it inheritsSequence[str].