[pycodestyle] Whitespace after decorator (E204)#12140
Merged
charliermarsh merged 12 commits intoastral-sh:mainfrom Jul 4, 2024
Merged
[pycodestyle] Whitespace after decorator (E204)#12140charliermarsh merged 12 commits intoastral-sh:mainfrom
pycodestyle] Whitespace after decorator (E204)#12140charliermarsh merged 12 commits intoastral-sh:mainfrom
Conversation
pycodestyle] Whitespace after decorator (E204)
charliermarsh
approved these changes
Jul 4, 2024
Member
charliermarsh
left a comment
There was a problem hiding this comment.
Thanks! I added a fix too.
306995a to
858ea10
Compare
858ea10 to
0dfec9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the implementation for the new rule of
pycodestyle (E204). It follows the guidlines described in the contributing site, and as such it has a new file namedwhitespace_after_decorator.rs, a new test file calledE204.py, and as such invokes thefunctionin theAST statement checkerfor functions and functions in classes. Linking #2402 because it has all the pycodestyle rules.Test Plan
The file E204.py, has a
decoratordefined called wrapper, and this decorator is used for 2 cases. The first one is when afunctionwhich has adecoratoris called in the file, and the second one is when there is aclassand 2methodsare defined for theclasswith adecoratorattached it.Test file:
I am still new to rust and any suggestion is appreciated. Specially with the way im using native ruff utilities.