Revert "Use correct range to highlight line continuation error"#12089
Merged
dhruvmanila merged 1 commit intomainfrom Jun 28, 2024
Merged
Revert "Use correct range to highlight line continuation error"#12089dhruvmanila merged 1 commit intomainfrom
dhruvmanila merged 1 commit intomainfrom
Conversation
Contributor
|
MichaReiser
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #12016 with a small change where the error location points to the continuation character only. Earlier, it would also highlight the whitespace that came before it.
The motivation for this change is to avoid panic in #11950. For example:
Playground: https://play.ruff.rs/87711071-1b54-45a3-b45a-81a336a1ea61
The range of
Unknowntoken andRparis the same. Once #11950 is enabled, the indexer would panic. It won't panic in the stable version because we stop at the firstUnknowntoken.