Avoid moving back the lexer for triple-quoted fstring#11939
Merged
dhruvmanila merged 1 commit intomainfrom Jun 20, 2024
Merged
Conversation
Contributor
|
8f1ccc9 to
9ba57f4
Compare
MichaReiser
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR avoids moving back the lexer for a triple-quoted f-string during the re-lexing phase.
The reason this is a problem is that for a triple-quoted f-string the newlines are part of the f-string itself, specifically they'll be part of the
FStringMiddletoken. So, if we moved the lexer back, there would be aNewlinetoken whose range would be in between anFStringMiddletoken. This creates a panic in downstream usage.fixes: #11937
Test Plan
Add test cases and validate the snapshots.