Use real file path when available in ruff server#11800
Merged
snowsignal merged 1 commit intomainfrom Jun 8, 2024
Merged
Conversation
Contributor
|
snowsignal
approved these changes
Jun 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As-is, we're using the URL path for all files, leading us to use paths like:
This doesn't match against per-file ignores and other patterns in Ruff configuration.
This PR modifies the LSP to use the real file path if available, and the virtual file path if not.
Closes #11751.
Test Plan
Ran the LSP on Windows. In the FastAPI repo, added:
And verified that an unused import was ignored in
testsafter this change, but not before.