[pygrep_hooks] Move blanket-noqa to noqa checker (PGH004)#11053
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Apr 22, 2024
Merged
[pygrep_hooks] Move blanket-noqa to noqa checker (PGH004)#11053charliermarsh merged 1 commit intoastral-sh:mainfrom
pygrep_hooks] Move blanket-noqa to noqa checker (PGH004)#11053charliermarsh merged 1 commit intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 6 | 3 | 3 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+3 -3 violations, +0 -0 fixes in 2 projects; 42 projects unchanged)
bokeh/bokeh (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ src/bokeh/embed/util.py:146:32: RUF100 [*] Unused blanket `noqa` directive - src/bokeh/embed/util.py:146:32: RUF100 [*] Unused blanket `noqa` directive
rotki/rotki (+2 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ pytestgeventwrapper.py:1:48: RUF100 [*] Unused blanket `noqa` directive - pytestgeventwrapper.py:1:48: RUF100 [*] Unused blanket `noqa` directive + pytestgeventwrapper.py:2:34: RUF100 [*] Unused blanket `noqa` directive - pytestgeventwrapper.py:2:34: RUF100 [*] Unused blanket `noqa` directive
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 6 | 3 | 3 | 0 | 0 |
MichaReiser
approved these changes
Apr 22, 2024
Member
|
Uhh, what are the differences in the ecosystem check. Are the ranges different? |
Contributor
Author
|
It's because the reporting order gets switched. After |
Member
|
Oh hah that's funny. Thanks for looking into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
blanket-noqarule from the token checker to the noqa checker. This allows us to make use of the line directives already computed in the noqa checker.Test Plan
Verified test results are unchanged.