Skip to content

Move Q003 to AST checker#10923

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/move-q003
Apr 14, 2024
Merged

Move Q003 to AST checker#10923
dhruvmanila merged 1 commit intomainfrom
dhruv/move-q003

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila commented Apr 14, 2024

Summary

This PR moves the Q003 rule to AST checker.

This is the final rule that used the docstring detection state machine and thus this PR removes it as well.

resolves: #7595
resolves: #7808

Test Plan

  • cargo test
  • Make sure there are no changes in the ecosystem

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Apr 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila marked this pull request as ready for review April 14, 2024 16:39
@dhruvmanila dhruvmanila merged commit f9a828f into main Apr 14, 2024
@dhruvmanila dhruvmanila deleted the dhruv/move-q003 branch April 14, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify Q003 implementation First string token is always considered as docstring

2 participants