[ruff] Fix panic in unused # noqa removal with multi-byte space (RUF100)#10682
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Apr 1, 2024
Merged
[ruff] Fix panic in unused # noqa removal with multi-byte space (RUF100)#10682charliermarsh merged 4 commits intoastral-sh:mainfrom
ruff] Fix panic in unused # noqa removal with multi-byte space (RUF100)#10682charliermarsh merged 4 commits intoastral-sh:mainfrom
Conversation
b56aa02 to
2785331
Compare
Contributor
|
ruff] - Fix panic in (RUF100)ruff] - Fix panic (RUF100)
ruff] - Fix panic (RUF100)ruff] Fix panic in unused # noqa removal with multi-byte space (RUF100)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, this line assumes that the
noqacomment begins with an octothorpe followed by a space. (#) With anyone's random code, this of course is not always true.When there's a multi-byte character after the leading octothorpe, such as
\u0085, we try slicing from within the character, causing a panic.To fix this, the logic has been changed to remove unused
noqadirectives and keep any trailing comments, or removing the whole comment if the comment is just the unusednoqaFixes #10097.
Test Plan
cargo test