Respect Unicode characters in import sorting#10529
Merged
charliermarsh merged 1 commit intomainfrom Mar 22, 2024
Merged
Conversation
AlexWaygood
approved these changes
Mar 22, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
This looks correct to me.
I worry that there might be similar issues in other rules that do autofixes -- it seems reasonable to rely on the id of a Name node being the same as in the original source, and then using it for autofixes. So, maybe eagerly normalizing unicode identifiers in the lexer is a bit of a bug magnet now ://
zanieb
approved these changes
Mar 22, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that we use the raw identifier as provided in the source code, rather than the normalized Unicode identifier.
This does mean that we treat these as two separate identifiers, and don't merge them, even though Python will treat them as the same symbol:
I think that's fine, this is super rare anyway and would likely be confusing for users.
Closes #10528.
Test Plan
cargo test