Don't treat annotations as redefinitions in .pyi files#10512
Merged
charliermarsh merged 1 commit intomainfrom Mar 21, 2024
Merged
Don't treat annotations as redefinitions in .pyi files#10512charliermarsh merged 1 commit intomainfrom
.pyi files#10512charliermarsh merged 1 commit intomainfrom
Conversation
cc1b709 to
3565840
Compare
Member
|
Nice, this looks good! Let me just run this branch on typeshed quickly. |
AlexWaygood
approved these changes
Mar 21, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Confirmed that it fixes the regressions for typeshed, and doesn't introduce any new ones (with our current config, at least)!
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #10341, we fixed some false positives in
.pyifiles, but introduced others. This PR effectively reverts the change in #10341 and fixes it in a slightly different way. Instead of changing the bindings we generate in the semantic model in.pyifiles, we instead change how we resolve them.Closes #10509.