Allow trailing ellipsis in typing.TYPE_CHECKING#10413
Merged
charliermarsh merged 2 commits intoastral-sh:mainfrom Mar 15, 2024
Merged
Allow trailing ellipsis in typing.TYPE_CHECKING#10413charliermarsh merged 2 commits intoastral-sh:mainfrom
typing.TYPE_CHECKING#10413charliermarsh merged 2 commits intoastral-sh:mainfrom
Conversation
Trailing ellipses in objects defined in `typing.TYPE_CHECKING` might be meaningful (it might be declaring a stub). Thus, we should skip the `unnecessary-placeholder` (`PIE970`) rule in such contexts.
Contributor
|
| // user might be using the type-checking context to declare a stub. | ||
| if checker.semantic().in_type_checking_block() { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Should this be down at the in_protocol_or_abstract_method line? (I.e., shouldn't this only apply to ellipses, not stubs?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trailing ellipses in objects defined in
typing.TYPE_CHECKINGmight be meaningful (it might be declaring a stub). Thus, we should skip theunnecessary-placeholder(PIE970) rule in such contexts.Closes #10358.
Test Plan
cargo nextest run