On the latest version of ruff (0.0.278) this fails on the following code:
ruff --select RET503,RET505 test.py --fix --isolated
# test.py:11:9: RET505 Unnecessary `else` after `return` statement
def main(value: str) -> int | None:
if value == "one":
return 1
if value.startswith("do_stuff"):
print("doing stuff")
if value.endswith("haha"):
print("haha")
else:
print("Instruction unclear.")
else:
print("Doing nothing.")That is because the autofix for RET503 inserts return None in all three
branches of the if/else tree:
--- test.py
+++ test.py
@@ -7,7 +7,10 @@
if value.endswith("haha"):
print("haha")
+ return None
else:
print("Instruction unclear.")
+ return None
else:
print("Doing nothing.")
+ return NoneBut that is not compliant with RET505.
The fix in this case is to insert return None at the end of the function instead of in each branch in the if/else tree.
def main(value: str) -> int | None:
if value == "one":
return 1
if value.startswith("do_stuff"):
print("doing stuff")
if value.endswith("haha"):
print("haha")
else:
print("Instruction unclear.")
else:
print("Doing nothing.")
return NoneNot sure it is worth the effort to update behavior of the RET503 autofix for this case. But I thought I should report it.
On the latest version of
ruff(0.0.278) this fails on the following code:ruff --select RET503,RET505 test.py --fix --isolated # test.py:11:9: RET505 Unnecessary `else` after `return` statementThat is because the autofix for RET503 inserts
return Nonein all threebranches of the if/else tree:
But that is not compliant with RET505.
The fix in this case is to insert
return Noneat the end of the function instead of in each branch in the if/else tree.Not sure it is worth the effort to update behavior of the
RET503autofix for this case. But I thought I should report it.