Skip to content

Commit 38f4d9e

Browse files
tjkusontjkuson
authored
Tweak relative-imports message (#9365)
## Summary Changes message from `"Relative imports are banned"` to `"Prefer absolute imports over relative imports from parent modules"`. Closes #9363. ## Test Plan `cargo test`
1 parent f07d350 commit 38f4d9e

File tree

4 files changed

+41
-39
lines changed

4 files changed

+41
-39
lines changed

‎crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,10 @@ impl Violation for RelativeImports {
5656
#[derive_message_formats]
5757
fn message(&self) -> String {
5858
match self.strictness {
59-
Strictness::Parents => format!("Relative imports from parent modules are banned"),
60-
Strictness::All => format!("Relative imports are banned"),
59+
Strictness::Parents => {
60+
format!("Prefer absolute imports over relative imports from parent modules")
61+
}
62+
Strictness::All => format!("Prefer absolute imports over relative imports"),
6163
}
6264
}
6365

‎crates/ruff_linter/src/rules/flake8_tidy_imports/snapshots/ruff_linter__rules__flake8_tidy_imports__tests__ban_all_imports.snap‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
source: crates/ruff_linter/src/rules/flake8_tidy_imports/mod.rs
33
---
4-
TID252.py:7:1: TID252 Relative imports are banned
4+
TID252.py:7:1: TID252 Prefer absolute imports over relative imports
55
|
66
6 | # TID252
77
7 | from . import sibling
@@ -11,7 +11,7 @@ TID252.py:7:1: TID252 Relative imports are banned
1111
|
1212
= help: Replace relative imports with absolute imports
1313

14-
TID252.py:8:1: TID252 Relative imports are banned
14+
TID252.py:8:1: TID252 Prefer absolute imports over relative imports
1515
|
1616
6 | # TID252
1717
7 | from . import sibling
@@ -22,7 +22,7 @@ TID252.py:8:1: TID252 Relative imports are banned
2222
|
2323
= help: Replace relative imports with absolute imports
2424

25-
TID252.py:9:1: TID252 Relative imports are banned
25+
TID252.py:9:1: TID252 Prefer absolute imports over relative imports
2626
|
2727
7 | from . import sibling
2828
8 | from .sibling import example
@@ -33,7 +33,7 @@ TID252.py:9:1: TID252 Relative imports are banned
3333
|
3434
= help: Replace relative imports with absolute imports
3535

36-
TID252.py:10:1: TID252 Relative imports are banned
36+
TID252.py:10:1: TID252 Prefer absolute imports over relative imports
3737
|
3838
8 | from .sibling import example
3939
9 | from .. import parent
@@ -44,7 +44,7 @@ TID252.py:10:1: TID252 Relative imports are banned
4444
|
4545
= help: Replace relative imports with absolute imports
4646

47-
TID252.py:11:1: TID252 Relative imports are banned
47+
TID252.py:11:1: TID252 Prefer absolute imports over relative imports
4848
|
4949
9 | from .. import parent
5050
10 | from ..parent import example
@@ -55,7 +55,7 @@ TID252.py:11:1: TID252 Relative imports are banned
5555
|
5656
= help: Replace relative imports with absolute imports
5757

58-
TID252.py:12:1: TID252 Relative imports are banned
58+
TID252.py:12:1: TID252 Prefer absolute imports over relative imports
5959
|
6060
10 | from ..parent import example
6161
11 | from ... import grandparent
@@ -66,7 +66,7 @@ TID252.py:12:1: TID252 Relative imports are banned
6666
|
6767
= help: Replace relative imports with absolute imports
6868

69-
TID252.py:13:1: TID252 Relative imports are banned
69+
TID252.py:13:1: TID252 Prefer absolute imports over relative imports
7070
|
7171
11 | from ... import grandparent
7272
12 | from ...grandparent import example
@@ -77,7 +77,7 @@ TID252.py:13:1: TID252 Relative imports are banned
7777
|
7878
= help: Replace relative imports with absolute imports
7979

80-
TID252.py:14:1: TID252 Relative imports are banned
80+
TID252.py:14:1: TID252 Prefer absolute imports over relative imports
8181
|
8282
12 | from ...grandparent import example
8383
13 | from .parent import hello
@@ -90,7 +90,7 @@ TID252.py:14:1: TID252 Relative imports are banned
9090
|
9191
= help: Replace relative imports with absolute imports
9292

93-
TID252.py:17:1: TID252 Relative imports are banned
93+
TID252.py:17:1: TID252 Prefer absolute imports over relative imports
9494
|
9595
15 | parent import \
9696
16 | hello_world
@@ -104,7 +104,7 @@ TID252.py:17:1: TID252 Relative imports are banned
104104
|
105105
= help: Replace relative imports with absolute imports
106106

107-
TID252.py:21:1: TID252 Relative imports are banned
107+
TID252.py:21:1: TID252 Prefer absolute imports over relative imports
108108
|
109109
19 | import \
110110
20 | world_hello
@@ -115,7 +115,7 @@ TID252.py:21:1: TID252 Relative imports are banned
115115
|
116116
= help: Replace relative imports with absolute imports
117117

118-
TID252.py:22:1: TID252 Relative imports are banned
118+
TID252.py:22:1: TID252 Prefer absolute imports over relative imports
119119
|
120120
20 | world_hello
121121
21 | from ..... import ultragrantparent
@@ -126,7 +126,7 @@ TID252.py:22:1: TID252 Relative imports are banned
126126
|
127127
= help: Replace relative imports with absolute imports
128128

129-
TID252.py:23:1: TID252 Relative imports are banned
129+
TID252.py:23:1: TID252 Prefer absolute imports over relative imports
130130
|
131131
21 | from ..... import ultragrantparent
132132
22 | from ...... import ultragrantparent
@@ -137,7 +137,7 @@ TID252.py:23:1: TID252 Relative imports are banned
137137
|
138138
= help: Replace relative imports with absolute imports
139139

140-
TID252.py:24:1: TID252 Relative imports are banned
140+
TID252.py:24:1: TID252 Prefer absolute imports over relative imports
141141
|
142142
22 | from ...... import ultragrantparent
143143
23 | from ....... import ultragrantparent
@@ -148,7 +148,7 @@ TID252.py:24:1: TID252 Relative imports are banned
148148
|
149149
= help: Replace relative imports with absolute imports
150150

151-
TID252.py:25:1: TID252 Relative imports are banned
151+
TID252.py:25:1: TID252 Prefer absolute imports over relative imports
152152
|
153153
23 | from ....... import ultragrantparent
154154
24 | from ......... import ultragrantparent
@@ -159,7 +159,7 @@ TID252.py:25:1: TID252 Relative imports are banned
159159
|
160160
= help: Replace relative imports with absolute imports
161161

162-
TID252.py:26:1: TID252 Relative imports are banned
162+
TID252.py:26:1: TID252 Prefer absolute imports over relative imports
163163
|
164164
24 | from ......... import ultragrantparent
165165
25 | from ........................... import ultragrantparent
@@ -170,7 +170,7 @@ TID252.py:26:1: TID252 Relative imports are banned
170170
|
171171
= help: Replace relative imports with absolute imports
172172

173-
TID252.py:27:1: TID252 Relative imports are banned
173+
TID252.py:27:1: TID252 Prefer absolute imports over relative imports
174174
|
175175
25 | from ........................... import ultragrantparent
176176
26 | from .....parent import ultragrantparent
@@ -180,7 +180,7 @@ TID252.py:27:1: TID252 Relative imports are banned
180180
|
181181
= help: Replace relative imports with absolute imports
182182

183-
TID252.py:28:1: TID252 Relative imports are banned
183+
TID252.py:28:1: TID252 Prefer absolute imports over relative imports
184184
|
185185
26 | from .....parent import ultragrantparent
186186
27 | from .........parent import ultragrantparent

‎crates/ruff_linter/src/rules/flake8_tidy_imports/snapshots/ruff_linter__rules__flake8_tidy_imports__tests__ban_parent_imports.snap‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
source: crates/ruff_linter/src/rules/flake8_tidy_imports/mod.rs
33
---
4-
TID252.py:9:1: TID252 Relative imports from parent modules are banned
4+
TID252.py:9:1: TID252 Prefer absolute imports over relative imports from parent modules
55
|
66
7 | from . import sibling
77
8 | from .sibling import example
@@ -12,7 +12,7 @@ TID252.py:9:1: TID252 Relative imports from parent modules are banned
1212
|
1313
= help: Replace relative imports from parent modules with absolute imports
1414

15-
TID252.py:10:1: TID252 Relative imports from parent modules are banned
15+
TID252.py:10:1: TID252 Prefer absolute imports over relative imports from parent modules
1616
|
1717
8 | from .sibling import example
1818
9 | from .. import parent
@@ -23,7 +23,7 @@ TID252.py:10:1: TID252 Relative imports from parent modules are banned
2323
|
2424
= help: Replace relative imports from parent modules with absolute imports
2525

26-
TID252.py:11:1: TID252 Relative imports from parent modules are banned
26+
TID252.py:11:1: TID252 Prefer absolute imports over relative imports from parent modules
2727
|
2828
9 | from .. import parent
2929
10 | from ..parent import example
@@ -34,7 +34,7 @@ TID252.py:11:1: TID252 Relative imports from parent modules are banned
3434
|
3535
= help: Replace relative imports from parent modules with absolute imports
3636

37-
TID252.py:12:1: TID252 Relative imports from parent modules are banned
37+
TID252.py:12:1: TID252 Prefer absolute imports over relative imports from parent modules
3838
|
3939
10 | from ..parent import example
4040
11 | from ... import grandparent
@@ -45,7 +45,7 @@ TID252.py:12:1: TID252 Relative imports from parent modules are banned
4545
|
4646
= help: Replace relative imports from parent modules with absolute imports
4747

48-
TID252.py:17:1: TID252 Relative imports from parent modules are banned
48+
TID252.py:17:1: TID252 Prefer absolute imports over relative imports from parent modules
4949
|
5050
15 | parent import \
5151
16 | hello_world
@@ -59,7 +59,7 @@ TID252.py:17:1: TID252 Relative imports from parent modules are banned
5959
|
6060
= help: Replace relative imports from parent modules with absolute imports
6161

62-
TID252.py:21:1: TID252 Relative imports from parent modules are banned
62+
TID252.py:21:1: TID252 Prefer absolute imports over relative imports from parent modules
6363
|
6464
19 | import \
6565
20 | world_hello
@@ -70,7 +70,7 @@ TID252.py:21:1: TID252 Relative imports from parent modules are banned
7070
|
7171
= help: Replace relative imports from parent modules with absolute imports
7272

73-
TID252.py:22:1: TID252 Relative imports from parent modules are banned
73+
TID252.py:22:1: TID252 Prefer absolute imports over relative imports from parent modules
7474
|
7575
20 | world_hello
7676
21 | from ..... import ultragrantparent
@@ -81,7 +81,7 @@ TID252.py:22:1: TID252 Relative imports from parent modules are banned
8181
|
8282
= help: Replace relative imports from parent modules with absolute imports
8383

84-
TID252.py:23:1: TID252 Relative imports from parent modules are banned
84+
TID252.py:23:1: TID252 Prefer absolute imports over relative imports from parent modules
8585
|
8686
21 | from ..... import ultragrantparent
8787
22 | from ...... import ultragrantparent
@@ -92,7 +92,7 @@ TID252.py:23:1: TID252 Relative imports from parent modules are banned
9292
|
9393
= help: Replace relative imports from parent modules with absolute imports
9494

95-
TID252.py:24:1: TID252 Relative imports from parent modules are banned
95+
TID252.py:24:1: TID252 Prefer absolute imports over relative imports from parent modules
9696
|
9797
22 | from ...... import ultragrantparent
9898
23 | from ....... import ultragrantparent
@@ -103,7 +103,7 @@ TID252.py:24:1: TID252 Relative imports from parent modules are banned
103103
|
104104
= help: Replace relative imports from parent modules with absolute imports
105105

106-
TID252.py:25:1: TID252 Relative imports from parent modules are banned
106+
TID252.py:25:1: TID252 Prefer absolute imports over relative imports from parent modules
107107
|
108108
23 | from ....... import ultragrantparent
109109
24 | from ......... import ultragrantparent
@@ -114,7 +114,7 @@ TID252.py:25:1: TID252 Relative imports from parent modules are banned
114114
|
115115
= help: Replace relative imports from parent modules with absolute imports
116116

117-
TID252.py:26:1: TID252 Relative imports from parent modules are banned
117+
TID252.py:26:1: TID252 Prefer absolute imports over relative imports from parent modules
118118
|
119119
24 | from ......... import ultragrantparent
120120
25 | from ........................... import ultragrantparent
@@ -125,7 +125,7 @@ TID252.py:26:1: TID252 Relative imports from parent modules are banned
125125
|
126126
= help: Replace relative imports from parent modules with absolute imports
127127

128-
TID252.py:27:1: TID252 Relative imports from parent modules are banned
128+
TID252.py:27:1: TID252 Prefer absolute imports over relative imports from parent modules
129129
|
130130
25 | from ........................... import ultragrantparent
131131
26 | from .....parent import ultragrantparent
@@ -135,7 +135,7 @@ TID252.py:27:1: TID252 Relative imports from parent modules are banned
135135
|
136136
= help: Replace relative imports from parent modules with absolute imports
137137

138-
TID252.py:28:1: TID252 Relative imports from parent modules are banned
138+
TID252.py:28:1: TID252 Prefer absolute imports over relative imports from parent modules
139139
|
140140
26 | from .....parent import ultragrantparent
141141
27 | from .........parent import ultragrantparent

‎crates/ruff_linter/src/rules/flake8_tidy_imports/snapshots/ruff_linter__rules__flake8_tidy_imports__tests__ban_parent_imports_package.snap‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
source: crates/ruff_linter/src/rules/flake8_tidy_imports/mod.rs
33
---
4-
application.py:5:1: TID252 Relative imports from parent modules are banned
4+
application.py:5:1: TID252 Prefer absolute imports over relative imports from parent modules
55
|
66
3 | import attrs
77
4 |
@@ -12,7 +12,7 @@ application.py:5:1: TID252 Relative imports from parent modules are banned
1212
|
1313
= help: Replace relative imports from parent modules with absolute imports
1414

15-
application.py:6:1: TID252 [*] Relative imports from parent modules are banned
15+
application.py:6:1: TID252 [*] Prefer absolute imports over relative imports from parent modules
1616
|
1717
5 | from ....import unknown
1818
6 | from ..protocol import commands, definitions, responses
@@ -32,7 +32,7 @@ application.py:6:1: TID252 [*] Relative imports from parent modules are banned
3232
8 8 | from .. import server
3333
9 9 | from . import logger, models
3434

35-
application.py:6:1: TID252 [*] Relative imports from parent modules are banned
35+
application.py:6:1: TID252 [*] Prefer absolute imports over relative imports from parent modules
3636
|
3737
5 | from ....import unknown
3838
6 | from ..protocol import commands, definitions, responses
@@ -52,7 +52,7 @@ application.py:6:1: TID252 [*] Relative imports from parent modules are banned
5252
8 8 | from .. import server
5353
9 9 | from . import logger, models
5454

55-
application.py:6:1: TID252 [*] Relative imports from parent modules are banned
55+
application.py:6:1: TID252 [*] Prefer absolute imports over relative imports from parent modules
5656
|
5757
5 | from ....import unknown
5858
6 | from ..protocol import commands, definitions, responses
@@ -72,7 +72,7 @@ application.py:6:1: TID252 [*] Relative imports from parent modules are banned
7272
8 8 | from .. import server
7373
9 9 | from . import logger, models
7474

75-
application.py:7:1: TID252 [*] Relative imports from parent modules are banned
75+
application.py:7:1: TID252 [*] Prefer absolute imports over relative imports from parent modules
7676
|
7777
5 | from ....import unknown
7878
6 | from ..protocol import commands, definitions, responses
@@ -93,7 +93,7 @@ application.py:7:1: TID252 [*] Relative imports from parent modules are banned
9393
9 9 | from . import logger, models
9494
10 10 | from ..protocol.UpperCaseModule import some_function
9595

96-
application.py:8:1: TID252 [*] Relative imports from parent modules are banned
96+
application.py:8:1: TID252 [*] Prefer absolute imports over relative imports from parent modules
9797
|
9898
6 | from ..protocol import commands, definitions, responses
9999
7 | from ..server import example
@@ -113,7 +113,7 @@ application.py:8:1: TID252 [*] Relative imports from parent modules are banned
113113
9 9 | from . import logger, models
114114
10 10 | from ..protocol.UpperCaseModule import some_function
115115

116-
application.py:10:1: TID252 [*] Relative imports from parent modules are banned
116+
application.py:10:1: TID252 [*] Prefer absolute imports over relative imports from parent modules
117117
|
118118
8 | from .. import server
119119
9 | from . import logger, models

0 commit comments

Comments
 (0)