better error message

AlexWaygood · AlexWaygood · commit 183ecab67b55 · 2024-09-10T13:59:05.000-04:00
diff --git a/crates/ruff_linter/src/rules/pyflakes/rules/undefined_name.rs b/crates/ruff_linter/src/rules/pyflakes/rules/undefined_name.rs
@@ -40,8 +40,7 @@ impl Violation for UndefinedName {
         } = self;
         let tip = minor_version_builtin_added.map(|version_added| {
             format!(
-                "Added as a builtin in Python 3.{version_added}; \
-consider specifying a newer `target-version` in your Ruff config."
+                r#"Consider specifying `requires-python = ">= 3.{version_added}"` or `tool.ruff.target-version = "py3{version_added}"` in your `pyproject.toml` file."#
             )
         });
 
diff --git a/crates/ruff_linter/src/rules/pyflakes/snapshots/ruff_linter__rules__pyflakes__tests__f821_with_builtin_added_on_new_py_version_but_old_target_version_specified.snap b/crates/ruff_linter/src/rules/pyflakes/snapshots/ruff_linter__rules__pyflakes__tests__f821_with_builtin_added_on_new_py_version_but_old_target_version_specified.snap
@@ -1,7 +1,7 @@
 ---
 source: crates/ruff_linter/src/rules/pyflakes/mod.rs
 ---
-<filename>:1:1: F821 Undefined name `PythonFinalizationError`. Added as a builtin in Python 3.13; consider specifying a newer `target-version` in your Ruff config.
+<filename>:1:1: F821 Undefined name `PythonFinalizationError`. Consider specifying `requires-python = ">= 3.13"` or `tool.ruff.target-version = "py313"` in your `pyproject.toml` file.
   |
 1 | PythonFinalizationError
   | ^^^^^^^^^^^^^^^^^^^^^^^ F821

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,7 @@ impl Violation for UndefinedName {`
`40`	`40`	`} = self;`
`41`	`41`	`let tip = minor_version_builtin_added.map(\|version_added\| {`
`42`	`42`	`format!(`
`43`		`- "Added as a builtin in Python 3.{version_added}; \`
`44`		-consider specifying a newer `target-version` in your Ruff config."
	`43`	+ r#"Consider specifying `requires-python = ">= 3.{version_added}"` or `tool.ruff.target-version = "py3{version_added}"` in your `pyproject.toml` file."#
`45`	`44`	`)`
`46`	`45`	`});`
`47`	`46`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`---`
`2`	`2`	`source: crates/ruff_linter/src/rules/pyflakes/mod.rs`
`3`	`3`	`---`
`4`		-<filename>:1:1: F821 Undefined name `PythonFinalizationError`. Added as a builtin in Python 3.13; consider specifying a newer `target-version` in your Ruff config.
	`4`	+<filename>:1:1: F821 Undefined name `PythonFinalizationError`. Consider specifying `requires-python = ">= 3.13"` or `tool.ruff.target-version = "py313"` in your `pyproject.toml` file.
`5`	`5`	`\|`
`6`	`6`	`1 \| PythonFinalizationError`
`7`	`7`	`\| ^^^^^^^^^^^^^^^^^^^^^^^ F821`