Conversation
597fb28 to
02b6bf3
Compare
|
I need to validate this works on other Python versions too, I only tested 3.14 in #457. A bit separately, I'm not sure how the SQLite checks passed without the patch at python/cpython#128322 since that was required in a test outside of |
indygreg
left a comment
There was a problem hiding this comment.
This looks correct. I'm surprised a non-working pkg-config survived this long in the project's history!
Although TBH I'm not sure how much it mattered before the C extensions stuff was ported to configure. And even post configure, our approach has historically been to spit out a Modules file explicitly defining how to compile extension modules, bypassing the CPython build system nearly entirely.
|
Running
So it looks like some readline/libedit config changes snuck in here as well. I want to say the new state is completely correct. The only concerning change here is |
|
And if we run a full
No changes to anything libxz related, which is good. If you look at the raw changes to the ELF binaries, it looks like a handful of new symbol references are introduced, which means Python is taking advantage of features that weren't detected/enabled before. So this all looks good to me. (It might be a good idea to have CI run diffoscope against the base branch and post a summary to the PR to make this kind of analysis more turnkey.) |
|
Thanks for doing those comparisons Greg! I was thinking it'd be wise to check what else changed but wasn't sure what the best way to do so is yet. I was going to diff the logs as a starting point 😭
That'd be sweet. I'll look into that. |
Closes #449