Skip to content

build: Add native-tls feature#26

Merged
woodruffw merged 2 commits intoastral-sh:mainfrom
pavelzw:native-tls
Feb 3, 2026
Merged

build: Add native-tls feature#26
woodruffw merged 2 commits intoastral-sh:mainfrom
pavelzw:native-tls

Conversation

@pavelzw
Copy link
Copy Markdown
Contributor

@pavelzw pavelzw commented Feb 2, 2026 •
edited
Loading

in rattler-build we need to support building without rustls but only with native-tls feature. how about adding a native-tls feature in ambient-id?

xref prefix-dev/rattler-build#2101, sigstore/sigstore-rust#51

❯ cargo tree -i rustls --no-default-features --features native-tls,reqwest-middleware --locked
warning: nothing to print.

To find dependencies that require specific target platforms, try to use option `--target all` first, and then narrow your search scope accordingly.

@pavelzw pavelzw marked this pull request as ready for review February 2, 2026 09:35
@pavelzw pavelzw mentioned this pull request Feb 2, 2026
Merged
@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Feb 3, 2026

Hi @pavelzw, thanks for the PR. This seems reasonable to me, but I'm curious if you know how it interacts with reqwest 0.13 -- there's another inflight PR for that as well (#21).

@pavelzw
Copy link
Copy Markdown
Contributor Author

pavelzw commented Feb 3, 2026 •
edited
Loading

ah interesting, thanks for spotting!

seems like the rustls featrure was just renamed (+ default changed).

https://github.com/seanmonstar/reqwest/releases/tag/v0.13.0
image

i would suggest adhering to their naming scheme, i.e. calling the feature already rustls instead of rustls-tls 👍🏻

updating reqwest after this pr should be a nothingburger. you just need to replace rustls = ["reqwest/rustls-tls", "reqwest/rustls-tls-native-roots"] with rustls = ["reqwest/rustls"]

@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Feb 3, 2026

Thanks!

@wolfv
Copy link
Copy Markdown

wolfv commented Feb 3, 2026

@woodruffw - is it possible to merge and cut a release?

@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Feb 3, 2026

@woodruffw - is it possible to merge and cut a release?

Yep, I'll do that shortly.

@woodruffw woodruffw merged commit 215abb8 into astral-sh:main Feb 3, 2026
3 checks passed
@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Feb 3, 2026

Thanks again @pavelzw!

This was referenced Feb 3, 2026
Merged
Merged
@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Feb 3, 2026 •
edited
Loading

#28

@pavelzw pavelzw deleted the native-tls branch February 3, 2026 11:45
@pavelzw
Copy link
Copy Markdown
Contributor Author

pavelzw commented Feb 3, 2026

thanks @woodruffw!

@pavelzw pavelzw mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelzw @woodruffw @wolfv