Add list of languages for ob-async to ignore#35
Merged
astahlman merged 3 commits intoastahlman:masterfrom Jun 24, 2018
Merged
Conversation
Owner
|
Looks good. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently noticed an incompatibility between this and the
ob-ipythonpackage, which defines its own:asynckeyword (and keeps an open pipe to an ipython session running in the background). To remedy this, I have added an elisp variableob-async-no-async-languages-alisthere: for any languages included in this list, the originalctrl-c-ctrl-cfunction is run — as it is for src blocks that do not include the:asynckeyword. By default, the variable is set tonil, so that there are no changes to the default behavior ofob-ipython.I've also included a test to show this functionality in action. By setting
ob-async-no-async-languages-alistto'("sh"), we can run one of the core tests, but expect that the code will finish before the check is run, circumventing the:asynckeyword.Let me know if something seems amiss, and I'm happy to update this. (...and thanks for writing this package; I use it all the time.)